jmark99 commented on a change in pull request #2551:
URL: https://github.com/apache/accumulo/pull/2551#discussion_r822644616
##########
File path: core/src/main/java/org/apache/accumulo/core/util/HostAndPort.java
##########
@@ -281,4 +282,13 @@ public int getPortOrDefault(int defaultPort) {
return hasPort() ? port : defaultPort;
}
+ /**
+ * HostAndPort must implement compareTo. As this is a seldom used utiltiy,
compareTo simply treats
+ * HostAndPort values as Strings.
+ */
+ @Override
+ public int compareTo(HostAndPort other) {
+ return
Comparator.nullsFirst(Comparator.comparing(HostAndPort::toString)).compare(this,
other);
Review comment:
@brianloss modified the comparator to treat port values as ints and
added test cases to verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
