ctubbsii commented on a change in pull request #2551:
URL: https://github.com/apache/accumulo/pull/2551#discussion_r822894763
##########
File path: core/src/main/java/org/apache/accumulo/core/util/HostAndPort.java
##########
@@ -281,4 +282,16 @@ public int getPortOrDefault(int defaultPort) {
return hasPort() ? port : defaultPort;
}
+ /**
+ * HostAndPort must implement compareTo. As this is a seldom used utility,
compareTo simply treats
+ * HostAndPort values as Strings.
+ */
+ @Override
+ public int compareTo(HostAndPort other) {
+ return Comparator
+ .nullsFirst(
+ Comparator.comparing(HostAndPort::getHost).thenComparingInt(h ->
h.getPortOrDefault(0)))
Review comment:
Does this still work if host is null? From the constructor, it doesn't
look like we require non-null hosts. This might fail to compare if the host is
null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
