EdColeman commented on code in PR #2691:
URL: https://github.com/apache/accumulo/pull/2691#discussion_r870227271
##########
server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/PropCacheCaffeineImpl.java:
##########
@@ -130,13 +135,18 @@ public Builder(final ZooPropLoader zooPropLoader, final
PropStoreMetrics metrics
}
public PropCacheCaffeineImpl build() {
- return new PropCacheCaffeineImpl(zooPropLoader, metrics, ticker);
+ return new PropCacheCaffeineImpl(zooPropLoader, metrics, ticker,
runTasksInline);
}
public Builder withTicker(final Ticker ticker) {
this.ticker = ticker;
return this;
}
+
+ public Builder forTests() {
Review Comment:
You could pass in the ticker here and remove the withTicker() method - the
ticker is only used for testing and if the in-lineing is also only for test,
the functionallity could just be located in one method. forTesting() seems to
express that better than withTicker(), but either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
