dlmarion commented on code in PR #2691:
URL: https://github.com/apache/accumulo/pull/2691#discussion_r870296101


##########
test/src/main/java/org/apache/accumulo/test/conf/store/ZooBasedConfigIT.java:
##########
@@ -371,24 +360,4 @@ public String toString() {
     }
   }
 
-  private static class TestTicker implements Ticker {

Review Comment:
   I didn't see where the fake timer was actually being used *and* the test 
passes without it. I'm good with adding it back, but can you explain how/where 
it's being used? The only place where the fake timer is being used is 
[here](https://github.com/apache/accumulo/blob/main/test/src/main/java/org/apache/accumulo/test/conf/store/ZooBasedConfigIT.java#L282)
 and its not clear to me how that works with the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to