keith-turner commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r883197611
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java:
##########
@@ -419,6 +438,7 @@ public Options getOptions() {
outputFileOpt.setArgName("file");
contextOpt.setArgName("context");
executionHintsOpt.setArgName("<key>=<value>{,<key>=<value>}");
+ scanServerOpt.setArgName("immediate|eventual");
Review Comment:
>That makes sense if the desired primary outcome was "eventual consistency".
It's not, though. It's merely an acceptable side-effect of what the user is
really asking for, and not its essential/sufficient characteristic.
I agree that a developer will enable eventual consistency because they want
better performance and/or availability and they are ok with stale data. One
important thing to consider is that for evaluating code for correctness (like I
am reviewing Accumulo code that someone else wrote) is that the consistency
level of the data returned by the scanner is extremely important (probably more
important than the performance benefits desired by the author). The fact that
a scanner may return stale data needs to be very clearly communicated when
considering other names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
