dlmarion commented on code in PR #2750:
URL: https://github.com/apache/accumulo/pull/2750#discussion_r891544324
##########
core/src/main/java/org/apache/accumulo/core/metadata/Reference.java:
##########
@@ -38,4 +38,28 @@ public Reference(TableId tableId, String metadataEntry) {
this.metadataEntry = metadataEntry;
this.tabletDir = metadataEntry;
}
+
+ @Override
+ public int compareTo(Reference that) {
+ if (equals(that)) {
+ return 0;
+ } else {
+ return this.metadataEntry.compareTo(that.metadataEntry);
+ }
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj instanceof Reference) {
+ Reference that = (Reference) obj;
+ return this.metadataEntry.equals(that.metadataEntry);
+ } else {
+ return false;
+ }
+ }
Review Comment:
Eclipse generates the following for equals here. My guess is that it might
be safer and faster.
```
if (this == obj)
return true;
if (obj == null)
return false;
if (getClass() != obj.getClass())
return false;
Reference other = (Reference) obj;
if (metadataEntry == null) {
if (other.metadataEntry != null)
return false;
} else if (!metadataEntry.equals(other.metadataEntry))
return false;
return true;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
