dlmarion commented on code in PR #2750:
URL: https://github.com/apache/accumulo/pull/2750#discussion_r892274396
##########
core/src/main/java/org/apache/accumulo/core/metadata/Reference.java:
##########
@@ -38,4 +38,28 @@ public Reference(TableId tableId, String metadataEntry) {
this.metadataEntry = metadataEntry;
this.tabletDir = metadataEntry;
}
+
+ @Override
+ public int compareTo(Reference that) {
+ if (equals(that)) {
+ return 0;
+ } else {
+ return this.metadataEntry.compareTo(that.metadataEntry);
+ }
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj instanceof Reference) {
+ Reference that = (Reference) obj;
+ return this.metadataEntry.equals(that.metadataEntry);
+ } else {
+ return false;
+ }
+ }
Review Comment:
To be clear, my only issue is that it appears that relative things are being
used in the metadata table due to class location. If only the GC process is
creating relative file reference objects for use at runtime, then you would
only know that by tracing through the code to see where things are used /
created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
