milleruntime commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r938999875


##########
core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java:
##########
@@ -373,6 +384,23 @@ default void forEach(BiConsumer<? super Key,? super Value> 
keyValueConsumer) {
     }
   }
 
+  /**
+   * Get the configured consistency level
+   *
+   * @return consistency level
+   * @since 2.1.0
+   */
+  public ConsistencyLevel getConsistencyLevel();
+
+  /**
+   * Set the desired consistency level for this scanner.
+   *
+   * @param level
+   *          consistency level
+   * @since 2.1.0
+   */
+  public void setConsistencyLevel(ConsistencyLevel level);
+

Review Comment:
   What about just a single method like `useSnapshot()` which will override the 
default behavior of the Scanner. This is less confusing to me then using the 
Consistency terminology and doesn't require an Enum. From a user perspective, I 
think the idea that you are using a snapshot of the data from some previous 
point in time is pretty clear and easier to explain.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to