dlmarion commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r939052009
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/scan/ScanTask.java:
##########
@@ -127,9 +154,6 @@ public T get(long timeout, TimeUnit unit)
// returned
resultQueue = null;
- if (r instanceof Error)
- throw (Error) r; // don't wrap an Error
-
Review Comment:
The places where ScanTask.addResult are called from (LookupTask.run and
NextBatchTask.run) where previously
[modified](https://github.com/apache/accumulo/commit/bbd87a6693fc5cdbbe947b0821a4f05a18cf905b)
to not catch `Throwable` and only catch `Exception`. `Error`'s that are thrown
from `LookupTask` and `NextBatchTask` should now be handled by the
`AccumuloUncughtExceptionHandler`. `Error`'s should not be on the queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
