ctubbsii commented on PR #3093: URL: https://github.com/apache/accumulo/pull/3093#issuecomment-1325989078
> @ctubbsii - I'm thinking that we don't need to move the Thrift generated code to another repo. I think that if we trust what Thrift generates as being correct (which is basically what we do now), then we can: > > 1. use the `.gitattributes` to make it easier to review changes that involve modifications to the Thrift IDL files > 2. not worry about potentially malicious changes to the Thrift generated code because it's generated automatically by the build to match the IDL, so the tests are always using the latest. I get these goals, but I don't understand how the contents in this PR help facilitate item 2. What is the expected workflow that would make use of this? If we just want GitHub Actions to regenerate the thrift to ensure that the files in the PR were generated correctly, then it seems like that would be a GitHub Actions task that installs the thrift compiler and runs the build with the thrift profile, but skipping tests, then simply checking if the git workspace got dirty. That's one possible workflow that doesn't involve docker at all. I don't understand the workflow you're envisioning that involves docker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
