ctubbsii commented on PR #3093: URL: https://github.com/apache/accumulo/pull/3093#issuecomment-1331165623
I think adding the .gitattributes is sufficient to suppress the generated stuff from code review. The follow-up task to check that the generated code is correct should address any code review gap left by this suppression (PRs can also be checked manually by running a built locally with the thrift profile, so the follow-up task is only a "nice to have"). Any other thing to help users create a development environment, such as Codespaces, seems out of scope for this issue, and could exist outside this repository. Personally, I don't see Codespaces getting much use, since most devs I know prefer to develop locally and to heavily customize their development environment to optimize their workflow. But, even if it is useful for some, it's really a separate issue from this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
