ctubbsii commented on code in PR #3122:
URL: https://github.com/apache/accumulo/pull/3122#discussion_r1048994404
##########
server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java:
##########
@@ -106,7 +106,7 @@ public static PermissionHandler
getPermHandler(ServerContext context) {
protected SecurityOperation(ServerContext context, Authorizor author,
Authenticator authent,
PermissionHandler pm) {
this.context = context;
- zkUserPath = Constants.ZROOT + "/" + context.getInstanceID() + "/users";
+ zkUserPath = Constants.ZROOT + "/" + context.getInstanceID() +
Constants.ZUSERS;
Review Comment:
A good end goal would be to have our ZK connections chroot'd, so we don't
have to prefix everything with the path to the instanceID. But, in order to
achieve that goal, it would be easier if the paths were concatenated in fewer
places. I proposed the improvement here, because I know it would serve that end
goal, and it basically changes the same lines that are already being modified
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
