ctubbsii commented on code in PR #3122:
URL: https://github.com/apache/accumulo/pull/3122#discussion_r1051494664
##########
server/base/src/main/java/org/apache/accumulo/server/ServerContext.java:
##########
@@ -113,6 +114,7 @@ private ServerContext(ServerInfo info) {
serverDirs = info.getServerDirs();
propStore = memoize(() -> ZooPropStore.initialize(getInstanceID(),
getZooReaderWriter()));
+ zkUserPath = memoize(() -> Constants.ZROOT + "/" + getInstanceID() +
Constants.ZUSERS);
Review Comment:
I recommended memoize because `getInstanceID()` may not be ready right away.
We have had some bootstrapping issues with this, especially around the
Initialize code. I could have been overly cautious in my recommendation,
though. It might not actually be needed here. If it's not, I'm fine with
dropping that bit and just making it a final String.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
