dlmarion commented on code in PR #3150:
URL: https://github.com/apache/accumulo/pull/3150#discussion_r1064591752


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java:
##########
@@ -896,6 +918,10 @@ public InitialMultiScan startMultiScan(TInfo tinfo, 
TCredentials credentials,
           ssio, authorizations, waitForWrites, tSamplerConfig, batchTimeOut, 
contextArg,
           executionHints, getBatchScanTabletResolver(tablets), busyTimeout);
 
+      if (!reservation.getFailures().isEmpty()) {
+        ims.result.setFailures(reservation.getFailures());
+      }
+

Review Comment:
   Addressed in 381dac3



##########
server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java:
##########
@@ -500,13 +510,13 @@ private Map<KeyExtent,TabletMetadata> 
reserveFilesInner(Collection<KeyExtent> ex
       var tabletMetadata = tabletsMetadata.get(extent);
       if (tabletMetadata == null) {
         LOG.info("RFFS {} extent not found in metadata table {}", 
myReservationId, extent);
-        throw new NotServingTabletException(extent.toThrift());
+        failures.add(extent);
       }
 
       if (!AssignmentHandler.checkTabletMetadata(extent, null, tabletMetadata, 
true)) {
         LOG.info("RFFS {} extent unable to load {} as AssignmentHandler 
returned false",
             myReservationId, extent);
-        throw new NotServingTabletException(extent.toThrift());
+        failures.add(extent);

Review Comment:
   Addressed in 381dac3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to