cshannon commented on PR #3136: URL: https://github.com/apache/accumulo/pull/3136#issuecomment-1399303663
@ctubbsii and @dlmarion - I just pushed a new update and I have significantly reworked the PR. There's still work to be done...comments need updating, some tests still need fixing and to be updated, and there is still some old VFS references laying around, etc. But it's in a good enough state to be looked at again to make sure this new direction is correct before I finish polishing everything up. The latest update now implements the agreed upon behavior of just re-using the existing 2 properties `general.context.class.loader.factory` and `table.class.loader.context` If not specified the `DefaultContextClassLoaderFactory` now will just load a new `URLClassLoader` and use the table context property as a list of URIs. I got rid of the ContextManager and simplified things to just cache classloaders for a period of time in a cache (for how long is something I wasn't sure of yet). I got rid of the complex logic to remove contexts as it seemed unnecessary and a simple Caffeine cache should work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
