dlmarion commented on code in PR #3136:
URL: https://github.com/apache/accumulo/pull/3136#discussion_r1086632609
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -1058,45 +1044,6 @@ public enum Property {
+ "constraint.",
"2.0.0"),
- // VFS ClassLoader properties
-
- // this property shouldn't be used directly; it exists solely to document
the default value
- // defined by its use in AccumuloVFSClassLoader when generating the property
documentation
- @Deprecated(since = "2.1.0", forRemoval = true)
- VFS_CLASSLOADER_SYSTEM_CLASSPATH_PROPERTY(
-
org.apache.accumulo.start.classloader.vfs.AccumuloVFSClassLoader.VFS_CLASSLOADER_SYSTEM_CLASSPATH_PROPERTY,
- "", PropertyType.STRING,
- "Configuration for a system level vfs classloader. Accumulo jar can be"
- + " configured here and loaded out of HDFS.",
- "1.5.0"),
- @Deprecated(since = "2.1.0", forRemoval = true)
- VFS_CONTEXT_CLASSPATH_PROPERTY(
Review Comment:
I think we need a property like this, maybe called
GENERAL_CONTEXT_CLASSPATH_PREFIX, so that administrators/users can define the
classpaths for a context. Unless you accounted for this somewhere else, it's
possible I missed it. The current way users interact with this is to define
named classloader context and their paths, for example:
```
general.vfs.context.classpath.<contextName>=<some classpath>
```
Then, in supported places in the code, they can pass in the `contextName` to
use their custom supplied classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
