ddanielr opened a new pull request, #3173:
URL: https://github.com/apache/accumulo/pull/3173

   I'm looking for feedback on direction of thrift error handling.
   I'm not seeing the errors I'm expecting, so I'm attempting to figure out 
what disconnect I still have
   
   My expectation is that I would have ThriftPropertyExceptions returned for 
any `accumulo shell config command` that sets an invalid property. 
   
   However, I'm only getting exceptions back for setting properties on tables 
and namespaces.
   
   If I set a direct property without specifying a table or namespace, no 
exception is raised
   
   Invalid Table Property Example:
   ```
   root@uno test> config -s table.walog.enabled=foo -t test
   2023-01-25T18:38:29,837 [shell.Shell] ERROR: 
org.apache.accumulo.core.client.AccumuloException: 
ThriftPropertyException(property:table.walog.enabled, value:foo, 
description:Invalid property for : TablePropKey{TableId=1'} name: 
table.walog.enabled, value: foo)
   
   ```
   
   Invalid Namespace Property Example:
   ```
   test> config -s table.walog.enabled=foo -ns testns
   2023-01-25T18:40:50,534 [shell.Shell] ERROR: 
org.apache.accumulo.core.client.AccumuloException: 
ThriftPropertyException(property:table.walog.enabled, value:foo, 
description:Invalid property for : NamespacePropKey{NamespaceId=2'} name: 
table.walog.enabled, value: foo)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to