dlmarion commented on code in PR #3173:
URL: https://github.com/apache/accumulo/pull/3173#discussion_r1087066114
##########
server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java:
##########
@@ -434,7 +441,7 @@ public void setSystemProperty(TInfo info, TCredentials c,
String property, Strin
throw iae;
} catch (Exception e) {
Manager.log.error("Problem setting config property in zookeeper", e);
- throw new TException(e.getMessage());
+ throw new ThriftPropertyException(property, value, e.getMessage());
Review Comment:
Do you want this above where IllegalArgumentException is caught?
##########
core/src/main/thrift/client.thrift:
##########
@@ -90,6 +90,12 @@ exception ThriftSecurityException {
2:SecurityErrorCode code
}
+exception ThriftPropertyException {
Review Comment:
No need to put this exception in the client thrift IDL file. You can just
put it in the manager.thrift file unless you need to import it into other IDL
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
