EdColeman commented on code in PR #3160:
URL: https://github.com/apache/accumulo/pull/3160#discussion_r1087252944
##########
server/base/src/test/java/org/apache/accumulo/server/ServerContextTest.java:
##########
@@ -135,7 +135,8 @@ public void testCanRun() {
// ensure this fails with older versions; the oldest supported version is
hard-coded here
// to ensure we don't unintentionally break upgrade support; changing this
should be a conscious
// decision and this check will ensure we don't overlook it
- final int oldestSupported = 8;
+ // as of 3.0 we will only support upgrades from 2.1
+ final int oldestSupported = AccumuloDataVersion.ROOT_TABLET_META_CHANGES;
Review Comment:
The comment was pre-existing and I found it helpful - it stopped me in my
tracks to make sure that removing the previous versions was what was intended.
Removing upgrade versions should be rare and having it explicitly stated here
served as a good reminder / check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
