ctubbsii commented on code in PR #3160:
URL: https://github.com/apache/accumulo/pull/3160#discussion_r1088008352
##########
server/base/src/test/java/org/apache/accumulo/server/ServerContextTest.java:
##########
@@ -135,7 +135,8 @@ public void testCanRun() {
// ensure this fails with older versions; the oldest supported version is
hard-coded here
// to ensure we don't unintentionally break upgrade support; changing this
should be a conscious
// decision and this check will ensure we don't overlook it
- final int oldestSupported = 8;
+ // as of 3.0 we will only support upgrades from 2.1
+ final int oldestSupported = AccumuloDataVersion.ROOT_TABLET_META_CHANGES;
Review Comment:
I don't mean the whole comment... most of the comment is fine... I just
don't think it's useful to hard-code the version numbers into the comment,
because that's not really adding anything that the rest of the comment doesn't
already have... but by hard-coding these version names into the comment, it is
making it more that we have to change when we move forward, in order to keep
the comment current. I just think that's creating unnecessary work for
ourselves, and in this case, I don't think it makes it any more clear than what
was there before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
