ctubbsii commented on code in PR #3501:
URL: https://github.com/apache/accumulo/pull/3501#discussion_r1231555461
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java:
##########
@@ -91,7 +94,8 @@ public class TabletMetadata {
private boolean sawOldPrevEndRow = false;
private Text endRow;
private Location location;
- private Map<StoredTabletFile,DataFileValue> files;
+ private List<Pair<String,String>> rawFiles;
Review Comment:
Since there were a few smaller changes that tried to reduce costs, I wonder
which had the biggest impact, and which don't really matter. If there are a few
that are more readable and don't really matter, that might be a good balance.
Mostly, I'm worried about maintainability. However, if a follow on ticket is
created to address this (by perhaps improving StoredTabletFile) in 3.x, we can
probably defer any such readability improvements until then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
