ctubbsii commented on code in PR #3501:
URL: https://github.com/apache/accumulo/pull/3501#discussion_r1231558576
##########
core/src/main/java/org/apache/accumulo/core/util/Pair.java:
##########
@@ -23,8 +23,8 @@
import java.util.Objects;
public class Pair<A,B> {
- A first;
- B second;
+ final A first;
+ final B second;
Review Comment:
The subclass should probably be made to call `.getFirst()` and
`.getSecond()` instead. It doesn't really matter, I guess. Pair is not public
API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
