cshannon commented on PR #3509: URL: https://github.com/apache/accumulo/pull/3509#issuecomment-1601224624
This seems ok to me but will require a lot of refactoring to merge into main. AbstractTabletFile contains the file name now so I am wondering if the FileParts class will need to get moved there. Also things were renamed but the merge won't work since TabletFile still exists but is now an interface so git won't be able to figure out the old version got renamed. So when this is merged I can take a look at fixing main, probably through some manual fixing to make this patch work with the refactoring. I can re-run performance tests if everyone is good with the implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
