keith-turner commented on code in PR #3896:
URL: https://github.com/apache/accumulo/pull/3896#discussion_r1373744998


##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -407,6 +407,60 @@ private TableMgmtStats 
manageTablets(Iterator<TabletManagement> iter,
             state, goal, actions);
       }
 
+      // If the current tablet is hosted and the TabletServer that it's hosted 
on is being shut
+      // down, then we need to unhost tablets in order. We can't unassign the 
root tablet before
+      // moving any metadata table tablets that are on this host. We can't 
unassign metadata
+      // tablets before moving any user table tablets that are on this host.
+      if (current != null && state == TabletState.HOSTED

Review Comment:
   If a tablet server is hosting metadata and user tablet, it should be ok to 
unload the metadata tablet first if there is another tablet server that can 
host it.  Once the metadata tablet is loaded elsewhere the the user tablet can 
unload.  If all tservers are being shutdown, then it seems like the existing 
code should handle this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to