keith-turner commented on code in PR #3896:
URL: https://github.com/apache/accumulo/pull/3896#discussion_r1373806556


##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -407,6 +407,60 @@ private TableMgmtStats 
manageTablets(Iterator<TabletManagement> iter,
             state, goal, actions);
       }
 
+      // If the current tablet is hosted and the TabletServer that it's hosted 
on is being shut
+      // down, then we need to unhost tablets in order. We can't unassign the 
root tablet before
+      // moving any metadata table tablets that are on this host. We can't 
unassign metadata
+      // tablets before moving any user table tablets that are on this host.
+      if (current != null && state == TabletState.HOSTED

Review Comment:
   I am trying to understand the use case for the new code in this PR.  As long 
as there is another tablet server to load root or metadata tablet, then it 
should not matter what order they are unloaded in.  It only matters when all 
tablet servers are being shutdown, which I thought there was existing code to 
handle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to