dlmarion commented on code in PR #71:
URL: https://github.com/apache/accumulo-access/pull/71#discussion_r1669063409
##########
src/main/java/org/apache/accumulo/access/AccessEvaluator.java:
##########
@@ -149,7 +153,32 @@ static AccessEvaluator of(Authorizer authorizer) {
*
*/
static AccessEvaluator of(Collection<Authorizations> authorizationSets) {
- return new
AccessEvaluatorImpl(AccessEvaluatorImpl.convert(authorizationSets));
+ List<AccessEvaluatorImpl> evaluators = new
ArrayList<>(authorizationSets.size());
+ for (Authorizations authorizations : authorizationSets) {
+ evaluators.add(new AccessEvaluatorImpl(authorizations));
+ }
+
+ return new AccessEvaluator() {
Review Comment:
Ok, I think I understand this PR better now. You have modified
`AccessEvaluatorImpl` such that it only operates on a single `Authorizations`
object and moved the function of dealing with multiples into this anonymous
object. I have no issue with this, but wondering if we should/could move this
anonymous class to a concrete class, call it `AccessEvaluatorsImpl`,
`MultiAccessEvaluatorImpl`, or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
