keith-turner commented on code in PR #71:
URL: https://github.com/apache/accumulo-access/pull/71#discussion_r1669279988
##########
src/main/java/org/apache/accumulo/access/AccessEvaluator.java:
##########
@@ -149,7 +153,32 @@ static AccessEvaluator of(Authorizer authorizer) {
*
*/
static AccessEvaluator of(Collection<Authorizations> authorizationSets) {
- return new
AccessEvaluatorImpl(AccessEvaluatorImpl.convert(authorizationSets));
+ List<AccessEvaluatorImpl> evaluators = new
ArrayList<>(authorizationSets.size());
+ for (Authorizations authorizations : authorizationSets) {
+ evaluators.add(new AccessEvaluatorImpl(authorizations));
+ }
+
+ return new AccessEvaluator() {
Review Comment:
> but wondering if we should/could move this anonymous class to a concrete
class, call it AccessEvaluatorsImpl, MultiAccessEvaluatorImpl, or something
like that.
Yeah can do that, it would keep the interface file source code really
compact and it makes stacktraces a bit more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
