dlmarion commented on code in PR #4751:
URL: https://github.com/apache/accumulo/pull/4751#discussion_r1689645161
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1631,61 +1641,68 @@ public TreeMap<KeyExtent,TabletData> split(byte[] sp)
throws IOException {
Map<TabletFile,FileUtil.FileInfo> firstAndLastRows =
FileUtil.tryToGetFirstAndLastRows(context,
tableConfiguration, getDatafileManager().getFiles());
- synchronized (this) {
- // java needs tuples ...
- TreeMap<KeyExtent,TabletData> newTablets = new TreeMap<>();
+ // This must be acquired before the tablet lock AND completeClose expects
it to be acquired when
+ // called.
+ var lock = lockLogLock();
+ try {
+ synchronized (this) {
+ // java needs tuples ...
Review Comment:
There are Pair and Triple classes in commons-lang3. Immutable versions even.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
