dlmarion commented on code in PR #4751:
URL: https://github.com/apache/accumulo/pull/4751#discussion_r1689652016
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java:
##########
@@ -348,9 +348,7 @@ Optional<StoredTabletFile>
bringMinorCompactionOnline(TabletFile tmpDatafile,
metadataUpdateCount.updateAndGet(MetadataUpdateCount::incrementStart);
// do not place any code here between above stmt and following try{}finally
try {
- // Should not hold the tablet lock while trying to acquire the log lock
because this could
- // lead to deadlock. However there is a path in the code that does this.
See #3759
- tablet.getLogLock().lock();
+ var logLock = tablet.lockLogLock();
Review Comment:
should we make this `final` in all places where`lockLogLock` is called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
