ctubbsii commented on code in PR #80:
URL: https://github.com/apache/accumulo-access/pull/80#discussion_r1693294096
##########
src/main/java/org/apache/accumulo/access/BytesWrapper.java:
##########
@@ -21,12 +21,13 @@
import static java.nio.charset.StandardCharsets.UTF_8;
import java.util.Arrays;
+import java.util.Objects;
final class BytesWrapper implements Comparable<BytesWrapper> {
- protected byte[] data;
- protected int offset;
- protected int length;
+ private byte[] data;
+ private int offset;
+ private int length;
Review Comment:
That raises the question: is the class only intended for use internally
where we are using it carefully, or is it intended as part of this library's
public API? I ask because it appears to be public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
