keith-turner commented on code in PR #80:
URL: https://github.com/apache/accumulo-access/pull/80#discussion_r1693394791
##########
src/main/java/org/apache/accumulo/access/BytesWrapper.java:
##########
@@ -21,12 +21,13 @@
import static java.nio.charset.StandardCharsets.UTF_8;
import java.util.Arrays;
+import java.util.Objects;
final class BytesWrapper implements Comparable<BytesWrapper> {
- protected byte[] data;
- protected int offset;
- protected int length;
+ private byte[] data;
+ private int offset;
+ private int length;
Review Comment:
It is not part of the public API, its package private. The project has
[this
script](https://github.com/apache/accumulo-access/blob/main/src/build/ci/find-unapproved-public.sh)
that attempts to validate that only a small subset of types are public. The
project only has single package so the non public api stuff is set to package
private and then the script checks that.
I suppose we could also use the new Java module mechanisms for this project
since its new and so small, should hopefully be easy to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
