dlmarion commented on code in PR #5094:
URL: https://github.com/apache/accumulo/pull/5094#discussion_r1853912902
##########
assemble/bin/accumulo-cluster:
##########
@@ -573,49 +573,32 @@ function stop_all() {
}
function stop_here() {
- # Determine hostname without errors to user
- hosts_to_check=("$(hostname -a 2>/dev/null | head -1)" "$(hostname -f)")
-
if echo "${TSERVER_HOSTS}" | grep -Eq 'localhost|127[.]0[.]0[.]1'; then
Review Comment:
I'm wondering if the issue is really with this check. `start_here` gets the
local addresses using:
```
local_hosts="$(hostname -a 2>/dev/null) $(hostname) localhost 127.0.0.1
$(hostname -I)"
```
then iterates over `${TSERVER_HOSTS}`, and if there is a match, then it
starts the service. I'm thinking we should be doing the same thing here instead
of what we are currently doing. I'm concerned about calling `accumulo-service`
here vs calling it in `control_service` because as this change gets merged up
to `main` I don't think it will work the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
