ddanielr commented on code in PR #5094:
URL: https://github.com/apache/accumulo/pull/5094#discussion_r1854290155
##########
assemble/bin/accumulo-cluster:
##########
@@ -573,49 +573,32 @@ function stop_all() {
}
function stop_here() {
- # Determine hostname without errors to user
- hosts_to_check=("$(hostname -a 2>/dev/null | head -1)" "$(hostname -f)")
-
if echo "${TSERVER_HOSTS}" | grep -Eq 'localhost|127[.]0[.]0[.]1'; then
Review Comment:
Unlike `start-here`, there are only two reasons why this method needs
knowledge of its own hostname.
The first is for issuing an `admin stop` command to try and gracefully stop
the tserver via a FATE operation.
The second is for `control_service` to figure out if it needs to run a local
command or not.
However I'm not sure of the value of running that command as both this
commit and the previous code did not wait for the stop command to complete
successfully before starting to issue direct `stop` and `kill` commands to
`accumulo-service`.
If we bypass the fate step, then there's no reason to bother with looking at
the hostname for `stop-here` as accumulo-service lists all of the running
processes by looking at pid files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
