dlmarion commented on code in PR #5350:
URL: https://github.com/apache/accumulo/pull/5350#discussion_r1968105055


##########
server/base/src/main/java/org/apache/accumulo/server/conf/store/impl/PropStoreWatcher.java:
##########
@@ -100,15 +103,15 @@ public void process(final WatchedEvent event) {
       case NodeDataChanged:
         path = event.getPath();
         log.trace("handle change event for path: {}", path);
-        propStoreKey = PropStoreKey.fromPath(path);
+        propStoreKey = PropStoreKey.fromPath(path, instanceId);

Review Comment:
   Ok, the reason for asking is that I remember (but can't find it at the 
moment) something that I came across when implementing the persistent recursive 
watchers that have been merged into main that said the event path passed in the 
WatchedEvent was the full path. I assume that this means that it's the path to 
the node that changed, not where the persistent recursive watcher is set. 
However, we will want to test again in main that the chroot prefix is removed 
on the watched paths.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to