meatballspaghetti commented on code in PR #5350:
URL: https://github.com/apache/accumulo/pull/5350#discussion_r1974308865
##########
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java:
##########
@@ -543,7 +543,7 @@ public void execute(final String[] args) {
success = doInit(zk.asReaderWriter(), opts, fs, initConfig);
}
}
- } catch (IOException e) {
+ } catch (IOException | InterruptedException | KeeperException e) {
log.error("Problem trying to get Volume configuration", e);
success = false;
Review Comment:
Fixed, added separate catch blocks for each exception.
##########
server/base/src/main/java/org/apache/accumulo/server/init/ZooKeeperInitializer.java:
##########
@@ -79,40 +79,29 @@ void initializeConfig(final InstanceId instanceId, final
ZooReaderWriter zoo) {
if (zoo.exists(sysPropPath)) {
return;
}
- var created = zoo.putPrivatePersistentData(sysPropPath,
+ var created = zoo.putPrivatePersistentData(zkInstanceRoot + sysPropPath,
VersionedPropCodec.getDefault().toBytes(vProps),
ZooUtil.NodeExistsPolicy.FAIL);
if (!created) {
throw new IllegalStateException(
"Failed to create default system props during initialization at:
{}" + sysPropPath);
}
+ // if (!zoo.exists("/yea")) {
+ // throw new IllegalStateException("heres the stuff under
root/iid/config: "
+ // + Arrays.toString(zoo.getData(zkInstanceRoot + Constants.ZCONFIG)));
+ // }
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
