ctubbsii commented on PR #5365: URL: https://github.com/apache/accumulo/pull/5365#issuecomment-2691598780
I'm about to add a commit to this PR which I think helps some of these things. > * Be able to validate volumes independently of creating a server process if possible. Like validate config in a stand alone utility. I put the parsing code for volumes into ConfigurationTypeHelper and added a unit test to help support anything that needs to parse it, either for use or for validation. > * Support the concept that there is no default value but to be valid config for a system it must be set to a list of one ore more URIs. This one is tricky, because the PropertyType validation is tied to the Property enum which is so tightly coupled to our AccumuloConfiguration (including DefaultConfiguration). We have a separate ConfigCheckUtil, and maybe other places in the code that maybe could do validation of the configuration as a whole, like ensuring a property is set because it's a required property. But the PropertyType validation is really supposed to validate the format, *if set*. Making it required to be set is going to need to be done elsewhere, if it's not already done. > * If possible have the validation code reside in Property and PropertyType instead of off at some random place in the code. I moved the validation to PropertyType -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
