ctubbsii commented on PR #5365: URL: https://github.com/apache/accumulo/pull/5365#issuecomment-2691355258
I'm not sure how best to express the "empty is valid if only empty in the DefaultConfiguration, but not anywhere else" criteria that the tests are failing on. Typically, we have validators for the content of the property, based on the property type, and that's independent from the validation of the overall config, which might check several properties, or that some properties are set that are required, etc. So, for the PropertyType validator, it should probably just check that it is of the proper form *or* that it is empty (make empty valid) and then check that it's non-empty elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
