keith-turner commented on code in PR #5353:
URL: https://github.com/apache/accumulo/pull/5353#discussion_r1976447637
##########
server/manager/src/main/java/org/apache/accumulo/manager/merge/FindMergeableRangeTask.java:
##########
@@ -132,18 +133,17 @@ void submit(MergeableRange range, FateInstanceType type,
Entry<TableId,String> t
String endRowStr = StringUtils.defaultIfBlank(endRow.toString(), "+inf");
log.debug("FindMergeableRangeTask: Creating merge op: {} from startRow: {}
to endRow: {}",
tableId, startRowStr, endRowStr);
- var fateId = manager.fate(type).startTransaction();
- String goalMessage = TableOperation.MERGE + " Merge table " + tableName +
"(" + tableId
- + ") splits from " + startRowStr + " to " + endRowStr;
+ var fateKey = FateKey.forMerge(new KeyExtent(tableId, range.endRow,
range.startRow));
- manager.fate(type).seedTransaction(FateOperation.SYSTEM_MERGE, fateId,
+ manager.fate(type).seedTransaction(FateOperation.SYSTEM_MERGE, fateKey,
Review Comment:
This will wait for the data to be written to the walog of the fate table for
each operation seeded. W/ the changes in #5160 this is another place where
waiting on the walog per operation can be avoided.
##########
test/src/main/java/org/apache/accumulo/test/fate/FateStoreIT.java:
##########
@@ -683,8 +689,12 @@ protected void testListFateKeys(FateStore<TestEnv> store,
ServerContext sctx) th
var fateKey3 = FateKey.forCompactionCommit(cid1);
var fateKey4 = FateKey.forCompactionCommit(cid2);
+ // use one overlapping extent and one different
+ var fateKey5 = FateKey.forMerge(extent1);
Review Comment:
Not a change for this PR. Was looking around to see if FateKey had any unit
test that should be updated and did not see any. Could be useful to add some
unit test to check equals, hashcode, serder, etc in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
