cshannon commented on PR #5353: URL: https://github.com/apache/accumulo/pull/5353#issuecomment-2724732179
> Not something for this PR and maybe its never needed, but in addition to the periodic scan could also have scans triggered by events. Like if a `table.mergeability.threshold` is changed for a table or the mergability of some tablets are changed then trigger a scan. This is something that could be nice to add later if we need it, it would not be too hard so we can wait and see. > The test look good, is there anything else you were going to add? One other that would be nice is ensure the metadata table can automerge, this feature will be really nice to use w/ that table. I added all the tests I wanted to, in regards to to automerge for metadata that was something I forgot to bring up and wanted to ask about. Originally the default tablet for normal user table creation was set to "never "merge but that was [changed](https://github.com/apache/accumulo/pull/5353/files#diff-223656295941b1bcacbd49a1d0067f5f2c90af24c461f99ef5e490cdef21d2f0R262) in this PR to be "always" for user created tablets to allow merging back to one tablet if other splits are eligible for merging. However, the initial system tables still have their default tablets [marked](https://github.com/apache/accumulo/blob/0c79e44e2df29f8f9d8617fb698167a60c0512bb/server/base/src/main/java/org/apache/accumulo/server/init/FileSystemInitializer.java#L98) as never. One reason why was I was not sure if we wanted the system tables to be eligible to be auto merged or not. I assume by default it would be fine, if someone wants to manually split the metadata table, fate table, etc and keep tablets they can just mark those tablets as "never" merge like any other split if they want. But the metadata tablet is a bit special though as it is [initialized](https://github.com/apache/accumulo/blob/0c79e44e2df29f8f9d8617fb698167a60c0512bb/server/base/src/main/java/org/apache/accumulo/server/init/FileSystemInitializer.java#L163-L169) with 2 tablets and not 1 so I would assume we would never want to merge those both back together? And if so I was not sure how/if we should handle auto mergeability. Depending on what is decided here I can add another test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
