ddanielr commented on code in PR #5363:
URL: https://github.com/apache/accumulo/pull/5363#discussion_r1978034032
##########
core/src/main/java/org/apache/accumulo/core/spi/balancer/SimpleLoadBalancer.java:
##########
@@ -294,8 +294,8 @@ List<TabletMigration> move(ServerCounts tooMuch,
ServerCounts tooLittle, int cou
private TableId getTableToMigrate(ServerCounts tooMuch, Map<TableId,Integer>
tooMuchMap,
Map<TableId,Integer> tooLittleMap) {
- if (tableToBalance != null) {
Review Comment:
> @ddanielr the problem w/ TableLoadBalancerTest was related to this
removal. I added prints locally and ran the test and found that the simple load
balancer was balancing for all tabels w/o this even if it was given a smaller
set of tables. Tried to fix this in
[26a4c09](https://github.com/apache/accumulo/commit/26a4c09fad15dd1f716172cf7d066c5f0f162d38)
I tested your changes in isolation and found that that the underlying error
was a call to `TServerStatus.getTableMap()` that was just adding every table
and tablet count into the tables to consider for migrations. which you fixed
in
[26a4c09](https://github.com/apache/accumulo/commit/26a4c09fad15dd1f716172cf7d066c5f0f162d38)
Added an additional test for this by balancing a subset of the overall
tables and was able to replicate the failure in the SimpleLoadBalancerTest
before applying your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
