keith-turner commented on PR #5364: URL: https://github.com/apache/accumulo/pull/5364#issuecomment-2698536073
I looked into this and found what was causing the NPE. When a tablet server was run w/o metrics enabled prio to these changes the registry would never be set and the NPE would happen. So these changes are not masking a larger problem in the current code. The code that sets up these metrics is [here](https://github.com/apache/accumulo/blob/f297977bc7c9e10852ee269727d08ab7d9b6a14a/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java#L768-L776). The way that code is currently order it should set the registry before any compaction metrics are registered when metrics are enabled. Opened #5379 as a result of looking into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
