keith-turner commented on PR #5364: URL: https://github.com/apache/accumulo/pull/5364#issuecomment-2699318500
> I did not realize metrics could somehow be disabled for this (or how that would be done) leading to registry to never be init. This is the [code](https://github.com/apache/accumulo/blob/5847052ce7685ed4663d72963afc1f23c3c513f4/server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsInfoImpl.java#L120-L123) that caused the registry to not be set. I was in a hurry when I opened the issue so I did not include the context, I should have. I was running bulk import test using uno when I noticed the exception. I had to recreate that situation to cause the exception again and track down the cause. Turns most of our ITs enable metrics and uno does not. So never saw the problems in ITs, but always saw the exception in uno. > Also, when I merged this change up through main, the file did not exist in main, and I could not find any similar code existing in main, so the only things changed for this are 2.1 and 3.1. Does this seem correct? That is correct, the compaction metrics code is completely different in main and nothing needs to be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
