ctubbsii commented on code in PR #4816:
URL: https://github.com/apache/accumulo/pull/4816#discussion_r1982081238
##########
core/src/main/java/org/apache/accumulo/core/iterators/IteratorEnvironment.java:
##########
@@ -52,16 +52,16 @@ default AccumuloConfiguration getConfig() {
}
/**
- * Return the executed scope of the Iterator. Value will be one of the
following:
- * {@link IteratorScope#scan}, {@link IteratorScope#minc}, {@link
IteratorScope#majc}
+ * @return the executed scope of the Iterator. Value will be one of the
following:
+ * {@link IteratorScope#scan}, {@link IteratorScope#minc}, {@link
IteratorScope#majc}
*/
default IteratorScope getIteratorScope() {
throw new UnsupportedOperationException();
}
/**
- * Return true if the compaction is a full major compaction. Will throw
IllegalStateException if
- * {@link #getIteratorScope()} != {@link IteratorScope#majc}.
+ * @return true if the compaction is a full major compaction; false otherwise
+ * @throws IllegalStateException if {@link #getIteratorScope()} != {@link
IteratorScope#majc}.
Review Comment:
I was suggesting just having the boolean methods return true or false...
rather than throw an exception at all in some subset of "false" cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
