dlmarion commented on PR #4816:
URL: https://github.com/apache/accumulo/pull/4816#issuecomment-2815706400

   I'm coming late to this conversation, and I have not read all of the prior 
comments. I don't understand the design of the IteratorEnvironment interface, 
such that all of the methods have default implementations that throw an 
UnsupportedOperationException. If this has been addressed elsewhere, please 
point me to it and I'm happy to read through it.
   
   This type of interface design pattern enables implementations to not have to 
handle all of the methods, which might make it easier on the developer. But it 
makes it easier to run into a runtime exception instead of a compilation error. 
I think I'd rather see the fix for this remove the default exception throwing 
method implementations on the interface. I'm happy to start a different PR for 
this if that's out of scope for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to