keith-turner commented on code in PR #5350:
URL: https://github.com/apache/accumulo/pull/5350#discussion_r1999382209
##########
server/base/src/main/java/org/apache/accumulo/server/conf/util/ZooInfoViewer.java:
##########
@@ -231,13 +231,11 @@ private void printAcls(final ServerContext context, final
Opts opts, final Print
var conf = opts.getSiteConfiguration();
try (var zk = new ZooSession(getClass().getSimpleName(), conf)) {
- String instanceRoot = ZooUtil.getRoot(iid);
-
final Stat stat = new Stat();
recursiveAclRead(zk, ZROOT + ZINSTANCES, stat, aclMap);
- recursiveAclRead(zk, instanceRoot, stat, aclMap);
+ recursiveAclRead(zk, "/", stat, aclMap);
Review Comment:
Not sure but suspect this behavior may differ. Is this zookeeper chrooted?
If not is this reading all of zookeeper when it looks like it used to read a
single instances data?
##########
server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java:
##########
@@ -400,8 +400,7 @@ private void validateServerFamily(ArrayList<Short>
violations, ColumnUpdate colu
String lockId = new String(columnUpdate.getValue(), UTF_8);
try {
- lockHeld = ServiceLock.isLockHeld(context.getZooCache(),
- new ZooUtil.LockID(context.getZooKeeperRoot(), lockId));
+ lockHeld = ServiceLock.isLockHeld(context.getZooCache(), new
ZooUtil.LockID("", lockId));
Review Comment:
Seems like LockId used to strip the root and add it back. Now its mostly
stripping `/` and its kinda confusing, would be good to clean this behavior up
in a follow on PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
