ctubbsii commented on code in PR #5350:
URL: https://github.com/apache/accumulo/pull/5350#discussion_r1999518640


##########
server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java:
##########
@@ -400,8 +400,7 @@ private void validateServerFamily(ArrayList<Short> 
violations, ColumnUpdate colu
         String lockId = new String(columnUpdate.getValue(), UTF_8);
 
         try {
-          lockHeld = ServiceLock.isLockHeld(context.getZooCache(),
-              new ZooUtil.LockID(context.getZooKeeperRoot(), lockId));
+          lockHeld = ServiceLock.isLockHeld(context.getZooCache(), new 
ZooUtil.LockID("", lockId));

Review Comment:
   I noticed that some representations also omit the leading slash, so it's not 
clear to me if it the `/root/` is always stripped, or only `/root`. I also 
don't know if all the places where this is persisted, to ensure we cover all 
the edge cases during an upgrade.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to