dlmarion commented on code in PR #5512:
URL: https://github.com/apache/accumulo/pull/5512#discussion_r2063966348
##########
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java:
##########
@@ -107,17 +105,13 @@ public Configuration getConfiguration() {
@Override
public Configuration getConfiguration(TableId tableId) {
- Preconditions.checkArgument(tableId == TABLE_ID, "Expected " + TABLE_ID
+ " obtained"
- + " from IteratorEnvironment.getTableId(), but got: " + tableId);
return tableConf;
}
}
private static final byte[] EMPTY_BYTES = new byte[0];
private static final Range EMPTY_RANGE = new Range();
- private static final String TABLE_NAME = "rfileScanner";
- private static final TableId TABLE_ID = TableId.of(TABLE_NAME);
Review Comment:
Does validating the table id and throwing an exception change the behavior
of the code between the 2.1.3 and 2.1.4 releases? Are we going to introduce an
error into the clients use of our utility by upgrading?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
