dlmarion commented on code in PR #5512:
URL: https://github.com/apache/accumulo/pull/5512#discussion_r2063973048
##########
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java:
##########
@@ -107,17 +105,13 @@ public Configuration getConfiguration() {
@Override
public Configuration getConfiguration(TableId tableId) {
- Preconditions.checkArgument(tableId == TABLE_ID, "Expected " + TABLE_ID
+ " obtained"
- + " from IteratorEnvironment.getTableId(), but got: " + tableId);
return tableConf;
}
}
private static final byte[] EMPTY_BYTES = new byte[0];
private static final Range EMPTY_RANGE = new Range();
- private static final String TABLE_NAME = "rfileScanner";
- private static final TableId TABLE_ID = TableId.of(TABLE_NAME);
Review Comment:
Answering my own question - Looking at the 2.1.3 RFileScanner code, IterEnv
doesn't override `getServiceEnv`, `getPluginEnv` or `getTableId` so any usage
of those methods would throw an UnsupportedOperationException. We could add the
validation, or not, it doesn't matter as the methods aren't called in
RFileScanner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
