ctubbsii commented on PR #5515:
URL: https://github.com/apache/accumulo/pull/5515#issuecomment-2843443644
> If you can figure out how to do it in the pom, that would be great.
No, unfortunately, it can't be done. I forgot that profile activation in the
parent POM occurs before properties are read in the child POM. So, the property
has to be set outside. For my personal dev environment, I'm activating the
profile in my `~/.m2/settings.xml` instead.
```xml
<settings>
<activeProfiles>
<activeProfile>use-apache-snapshots</activeProfile>
</activeProfiles>
</settings>
```
> Also, I targeted the main branch only, and not 2.1, since we are pretty
late in the development cycle. I wasn't sure what risks might be associated
with bumping the parent pom version and figured that doing it on main only was
safe.
The risks for 2.1 are higher with the dependencies, not the plugins.
Updating the parent POM and build plugins are useful because they can help
reduce issues, or improve things, or add quality checks during the build for
releases, but aren't going to have the same risks of code behavior changes at
runtime that changing dependencies would have. Having a good, reliable,
consistent build, helps us effectuate releases, so it's good to keep that
maintained across all branches we are still releasing from.
It's not a big deal, though. If I am release manager for a release, this is
likely something I would have done as part of the release prep process anyway,
so if you don't backport these, and I manage the next 2.1 release, I'm likely
going to backport this anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
