keith-turner commented on code in PR #5576:
URL: https://github.com/apache/accumulo/pull/5576#discussion_r2109599925
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java:
##########
@@ -73,7 +73,8 @@ public class ThriftTransportPool {
private ThriftTransportPool(LongSupplier maxAgeMillis) {
this.maxAgeMillis = maxAgeMillis;
- this.checkThread = Threads.createThread("Thrift Connection Pool Checker",
() -> {
+ // TODO KEVIN RATHBUN all this does is perform some resource cleanup, so
may not be critical.
+ this.checkThread = Threads.createNonCriticalThread("Thrift Connection Pool
Checker", () -> {
Review Comment:
Looks like the ThriftTransportPool is only created in the ClientContext.
Maybe we could make ServerContext and ClientContext do something different that
leads to different behavior for client vs server for this thread. Seems like
halting the client would be bad.
Maybe
[this](https://github.com/apache/accumulo/blob/bdbe4f5173d49ddc347fc58be48796fe15a863b1/core/src/main/java/org/apache/accumulo/core/client/AccumuloClient.java#L329)
should somehow be used on the client side for this case, but nto sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
